set project_id and location when canceling BigQuery job #27521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:google
|
Should we have a test for this? |
lidalei
changed the title
lidalei
changed the title
potiuk
approved these changes
Nov 7, 2022
lidalei
commented
Nov 7, 2022
| @@ -203,7 +203,10 @@ def test_cancel_queries(self, mock_client, mock_poll_job_complete): | |||
| self.hook.running_job_id = running_job_id | |||
| self.hook.cancel_query() | |||
|
|
|||
| calls = [mock.call(job_id=running_job_id), mock.call(running_job_id)] | |||
| calls = [ | |||
There was a problem hiding this comment.
@uranusjr Thx for your comment. The two test cases test cancel_query which calls cancel_job. They also check the calls invoking poll_job_complete. So I think it is good enough. During test, I need to set an environment variable AIRFLOW_CONN_GOOGLE_CLOUD_DEFAULT=google-cloud-platform:https:// because the GoogleBaseHook calls get_connection in its constructor. I think we should move that function call within a member function. But it is out of the scope of this PR.
One concern is that cancel_query is being deprecated. When we fully deprecate it, we shall convert some of the test cases to cover cancel_job.
uranusjr
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue when canceling BigQuery jobs. The issue arises when the service account is in a Google Cloud project A but the job runs in another project B. The default project and location won't work anymore.