Adding dynamic entity reference tree inline widget #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonystar
reviewed
Mar 19, 2018
| @@ -11,3 +13,30 @@ | |||
| function bricks_dynamic_preprocess_field_multiple_value_form(&$variables) { | |||
| _bricks_preprocess_tabledrag_form($variables, 'element', 'bricks_tree_dynamic', $variables['element']['#field_name'] . '-delta-order'); | |||
| } | |||
|
|
|||
| function bricks_dynamic_inline_entity_form_reference_form_alter (&$reference_form, $form_state) { | |||
| $triggering_element = $form_state->getTriggeringElement(); | |||
tonystar
reviewed
Mar 19, 2018
bricks.module
Outdated
| @@ -109,6 +109,9 @@ function _bricks_nest_items($element, $items) { | |||
| } | |||
|
|
|||
| if ($parent_delta != -1) { | |||
| if (count($items[$parent_delta]['childs']) <= 0) { | |||
There was a problem hiding this comment.
Let's try to remove this and catch the error!
tonystar
reviewed
Mar 19, 2018
| @@ -11,3 +13,30 @@ | |||
| function bricks_dynamic_preprocess_field_multiple_value_form(&$variables) { | |||
| _bricks_preprocess_tabledrag_form($variables, 'element', 'bricks_tree_dynamic', $variables['element']['#field_name'] . '-delta-order'); | |||
| } | |||
|
|
|||
| function bricks_dynamic_inline_entity_form_reference_form_alter (&$reference_form, $form_state) { | |||
There was a problem hiding this comment.
Space _alter (&$reference_form!
tonystar
reviewed
Mar 19, 2018
| * label = @Translation("Bricks tree Dynamic (Inline entity form)"), | ||
| * description = @Translation("A tree of inline entity forms."), | ||
| * field_types = { | ||
| * "bricks", |
tonystar
reviewed
Mar 19, 2018
| * description = @Translation("A tree of inline entity forms."), | ||
| * field_types = { | ||
| * "bricks", | ||
| * "bricks_revisioned", |
tonystar
reviewed
Mar 19, 2018
| { | ||
| $name = $this->fieldDefinition->getName(); | ||
|
|
||
| if (isset($_POST[$name]['actions']['entity_type'])) { |
There was a problem hiding this comment.
Let's add comment with TODO!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.