Bricks for IEF #34
Bricks for IEF #34
Conversation
|
To be fixed:
|
|
I've implemented saving of |
bricks.edit.inc
Outdated
| @@ -102,7 +103,7 @@ function theme_bricks_tree_value_form($variables) { | |||
| drupal_add_tabledrag($table_id, 'depth', 'group', $element['#field_name'] . '-depth'); | |||
| // Fake call to enable indentation: | |||
| drupal_add_tabledrag($table_id, 'match', 'parent', $order_class); | |||
| drupal_add_js(drupal_get_path('module', 'bricks') . '/bricks.js'); | |||
| drupal_add_js(drupal_get_path('module', 'bricks') . '/bricks.js'); | |||
| $entities['#theme'] = 'bricks_inline_entity_form_table'; | ||
|
|
||
| foreach (element_children($entities) as $delta) { | ||
| $item = isset($context['items'][$delta]) ? $context['items'][$delta] : NULL; |
There was a problem hiding this comment.
How about to move this code in a helper function? Like in 8.x: https://github.com/highweb/drupal-bricks/blob/8.x-1.x/bricks.module#L233. And then use in both core module and bricks_inline.
| * | ||
| * @see bricks_inline_field_widget_form_alter() | ||
| */ | ||
| function theme_bricks_inline_entity_form_table($variables) { |
There was a problem hiding this comment.
As I figured out- here we have a copy-paste from http:https://cgit.drupalcode.org/inline_entity_form/tree/inline_entity_form.module?h=7.x-1.8#n1659 + modifications similar to https://github.com/berdyshev/drupal-bricks/blob/7.x-5.x/bricks.edit.inc#L44.
Let's split this function in two parts:
_template_preprocess_inline_entity_form_entity_table- copy-paste from IEF._bricks_preprocess_tabledrag_formhelper like in 8.x https://github.com/highweb/drupal-bricks/blob/8.x-1.x/bricks.module#L179.- And then call 1) and 2) in
bricks_inline_preprocess_inline_entity_form_entity_tablelike in 8.x: https://github.com/highweb/drupal-bricks/blob/8.x-1.x/modules/bricks_inline/bricks_inline.module#L25.
So, we can submit a patch in IEF and remove _template_preprocess_inline_entity_form_entity_table completely once accepted.
…m logic, and second - for bricks_inline
No description provided.