Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wakatime compact layout #560

Merged
merged 4 commits into from
Nov 4, 2020

Conversation

willianrod
Copy link
Contributor

Adds Wakatime compact layout as sugested in the previous pull request and in this issue #504

Here is the compact layout
a

Here is the normal layout
b

You can preview it here

@codecov
Copy link

codecov bot commented Oct 7, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@6e82cfb). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #560   +/-   ##
=========================================
  Coverage          ?   93.65%           
=========================================
  Files             ?       22           
  Lines             ?      662           
  Branches          ?      178           
=========================================
  Hits              ?      620           
  Misses            ?       38           
  Partials          ?        4           
Impacted Files Coverage Δ
src/cards/wakatime-card.js 98.50% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e82cfb...d5ec4b9. Read the comment docs.

@willianrod
Copy link
Contributor Author

I would appreciated if you could label this PR as hacktoberfest-accepted, having in mind your repository is not opted in to the Hacktoberfest.

@willianrod
Copy link
Contributor Author

@anuraghazra Do you have any question?

@anuraghazra
Copy link
Owner

Hi @willianrod thanks for the contribution, i'll review and merge the PR when i got some free time. :)

@anuraghazra anuraghazra added feature wakatime-card Issues related to the wakatime card. labels Oct 17, 2020
@willianrod
Copy link
Contributor Author

Meanwhile, can you add the label "hacktoberfest-accepted" to this PR?

@ghost
Copy link

ghost commented Oct 23, 2020

@willianrod @anuraghazra Is the possible add "Exclusive wakatime card param" like count or hideLessThan=5 (mins) for control count display languages?

i have something like that
image

@github-actions github-actions bot added doc-translation README doc translations. themes Feature, Enhancement, Fixes related to themes. labels Nov 4, 2020
@anuraghazra anuraghazra changed the base branch from master to infra-theme November 4, 2020 18:20
@anuraghazra anuraghazra changed the base branch from infra-theme to master November 4, 2020 18:20
@anuraghazra anuraghazra removed doc-translation README doc translations. themes Feature, Enhancement, Fixes related to themes. labels Nov 4, 2020
@anuraghazra anuraghazra merged commit 94aeabe into anuraghazra:master Nov 4, 2020
@anuraghazra
Copy link
Owner

Hey @willianrod thanks for the PR and sorry for the late response. :)

infinity-plus pushed a commit to infinity-plus/github-readme-stats that referenced this pull request Nov 9, 2020
* Add wakatime compact layout

* Update readme

* test: added & updated test snapshots

Co-authored-by: Anurag <[email protected]>
NightScript370 pushed a commit to NightScript370/github-readme-stats that referenced this pull request Dec 8, 2020
* Add wakatime compact layout

* Update readme

* test: added & updated test snapshots

Co-authored-by: Anurag <[email protected]>
@Muhammadyusuf96
Copy link

Muhammadyusuf96 commented Jan 8, 2021

Shows error on compact layout: Cannot read property 'length' of undefined
image
and end of lines isn't rounded:
image
(Chrome v87.0.4280.88)

Kab1r pushed a commit to Kab1r/github-readme-stats that referenced this pull request Apr 4, 2022
* Add wakatime compact layout

* Update readme

* test: added & updated test snapshots

Co-authored-by: Anurag <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted wakatime-card Issues related to the wakatime card.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants