Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[important] invalid/misspelled domains #27

Closed
dnmTX opened this issue Dec 18, 2018 · 12 comments
Closed

[important] invalid/misspelled domains #27

dnmTX opened this issue Dec 18, 2018 · 12 comments

Comments

@dnmTX
Copy link

dnmTX commented Dec 18, 2018

@anudeepND i was checking on the filtering progress on your lists in Ultimate-Hosts-Blacklist and there is a section for INVALID Domains which already has bunch of them listed.Some are misspelled,some has space in between,some are just nonexistent. Would advise to take a look and fix it on your end as they don't really serve any purpose but just being there.
If you need any help to sort them out,let me know.
Thank you 👍
For Example:
From INVALID domains: 0.0.0.0 miscellaneous
is 0.0.0.0 miscellaneous magnetic.t.domdex.com in your lists
and so on.....

@anudeepND
Copy link
Owner

@dnmTX Thanks for noticing me, I never looked at Invalid domain list at Ultimate-Hosts-Blacklist, I removed those domains from the host file 1407e6a

@dnmTX
Copy link
Author

dnmTX commented Dec 19, 2018

@anudeepND glad to help.I guess i can close this as you already fixed it. Just for the feature,check from time to time for any invalid domains there,looks like @funilrys's script doing excellent job finding them.
Closing....

@dnmTX dnmTX closed this as completed Dec 19, 2018
@anudeepND
Copy link
Owner

@dnmTX yes, will do.

@dnmTX
Copy link
Author

dnmTX commented Dec 19, 2018

@anudeepND unfortunately you missed some.Here is a list with some comments(let's hope i got them all this time):

0.0.0.0 2 ml.pubnative.net -i think on those three you just need to remove the "2"
0.0.0.0 2 p.skimresources.com
0.0.0.0 2 script.crazyegg.com

0.0.0.0 3 i.skimresources.com -same as above but "3"
0.0.0.0 3 t.skimresources.com

0.0.0.0 adbemdigitalmediarebootp rod2.112.2o7.net -both looked invalid to me
0.0.0.0 adbemdigitalmediarebootprod2.112.2o7.netadbemdigitalmediarebootprod2.112.2o7.net

0.0.0.0 http cdn.teads.tv -same as above
0.0.0.0 http trk.vidible.tv

0.0.0.0 mark.targ et.smi2.ru -just remove the space on this one

0.0.0.0 url p.adsymptotic.com -invalid
0.0.0.0 url p.skimresources.com

@anudeepND
Copy link
Owner

anudeepND commented Dec 19, 2018

@dnmTX I think there are a lot of them, I need to take a closer look. I was using Sublist3r sub domain scanner, all these invalid domain came from the results obtained by Sublist3r, I didn't verified each and every one of them, so they ended up in the final list. I will remove them as soon as I find them

@anudeepND
Copy link
Owner

@dnmTX I have removed most of the entries, there maybe some invalid entries present in the list. I will keep this issue open for a while.Thanks for reporting

@anudeepND
Copy link
Owner

bdf1ef1
59f1560
870506b

@funilrys
Copy link

funilrys commented Jan 2, 2019

Hi @anudeepND thanks for using the results of PyFunceble!

@dnmTX as we constantly retest them in case I update/change PyFunceble because of a new RFC or another new web/DNS practice, I don't think that it is a good idea to remove the INVALID elements from the database.

@dnmTX
Copy link
Author

dnmTX commented Jan 2, 2019

@funilrys @anudeepND HAPPY NEW YEAR GUYS
@funilrys i got your point but it makes me wonder what good are they doing in a folder that is design to collect invalid domains that came from the original lists during filtering.In our case here they're no longer present there(in the orig. lists).Maybe a sub folder for collecting a "old,no longer present invalid domains"? So they can pile up there and keep the main folder tight,with only the fresh ones.

@funilrys
Copy link

funilrys commented Jan 2, 2019

@dnmTX Happy New Year!!

Right, will create a new issue for tracking that 👍

@anudeepND
Copy link
Owner

@funilrys I understand, the domains I removed in the last commit was just demo sites, sftp, ftp domains related to the their company and jira bug tracking sites. If removed legit domains, I will recheck and add it to the list if necessary.
@dnmTX @funilrys Happy new year guys!

@anudeepND
Copy link
Owner

@dnmTX Closing for now, most of the invalid domains are removed from the list.

anudeepND added a commit that referenced this issue Jan 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants