fix: modeController is undefined while call removeBehaviors on a destroyed graph instance #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Yanyan-Wang
commented
Jun 15, 2023
Yanyan-Wang
commented
- fix: modeController is undefined while call removeBehaviors on a destroyed graph instance, closes: modeController is undefined #476;
- fix: ZoomCanvas props type, closes: ZoomCanvas中minZoom和maxZoom类型为undefined，导致TS检查报错 #458;
- feat: allow user to disable position auto adjust while close to canvas side for contextMenu, closes: Context Menu side switching #450
…royed graph instance, closes: #476
…s side for contextMenu
pomelo-nwu
approved these changes
Jun 19, 2023
| @@ -34,7 +35,7 @@ interface State { | |||
| let containerRef: HTMLDivElement | null; | |||
|
|
|||
| const ContextMenu: React.FunctionComponent<ContextMenuProps> & { Menu: typeof Menu } = props => { | |||
| const { children, bindType = 'node', style } = props; | |||
| const { children, bindType = 'node', autoAdjust = true, style } = props; | |||
There was a problem hiding this comment.
undefined 和 false 都会被设置为 true
graphin/src/components/ContextMenu 也需要修改下
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.