Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live view support #61

Merged
merged 6 commits into from
Nov 15, 2021
Merged

Live view support #61

merged 6 commits into from
Nov 15, 2021

Conversation

karlosmid
Copy link
Contributor

Good morning @antonmi .

I did a lighting talk at ElixirConfEu 2021 about respect and lack of LiveView support. You suggested a pull request, so here it is:

  1. support Phoenix.LiveViewTest
  2. rumbl mix upgrade to Phoenix 1.6

Copy link
Owner

@antonmi antonmi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great! Thank you! ❤️
Just a minor comment about .tool-versions

.tool-versions Outdated Show resolved Hide resolved
@antonmi
Copy link
Owner

antonmi commented Nov 15, 2021

Coolio-cool! I'll publish a new version soon!

@antonmi antonmi merged commit 18960a9 into antonmi:master Nov 15, 2021
@karlosmid karlosmid deleted the live_view_support branch November 17, 2021 08:01
@antonmi
Copy link
Owner

antonmi commented Nov 17, 2021

Hey @karlosmid !
I've published the 0.8.0 version with your changes!
Thanks for your collaboration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants