Append newline to autocomplete input if it's missing (fixes #303) #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OfftopicWhile browsing trough the code, I found this variable in the same file, which is instantly overwritten: Maybe worth to remove the first assignment. |
Test inputThis file can be used to test the autocomplete: It's missing the Sometimes it's hard to reproduce, as many IDEs put a |
|
Yes, var is not needed) |
antonmedv
requested changes
Apr 9, 2024
antonmedv
reviewed
Apr 9, 2024
internal/complete/complete.go
Outdated
| if input[len(input)-1] != '\n' { | ||
| input = append(input, '\n') | ||
| } | ||
| // Append newline to make sure that input is valid. |
There was a problem hiding this comment.
=) comment is wrong. new line is needed to not glue with next peace of code. also ; will work too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #303 by appending a newline to the autocomplete file input when it is missing.
The fix is tested and seems to work.