forked from JuliaLang/julia
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request JuliaLang#19472 from JuliaLang/vc/ssp
Fixes for LLVM 3.9 and Win64
- Loading branch information
Showing
2 changed files
with
48 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
From e95516f77127ca534775d5f8d8cbb6e2e9c3f993 Mon Sep 17 00:00:00 2001 | ||
From: Valentin Churavy <[email protected]> | ||
Date: Thu, 1 Dec 2016 18:48:30 +0900 | ||
Subject: [PATCH] Don't assume mingw is providing SSP functions | ||
|
||
Summary: | ||
Mingw is indirectly targeting msvcrt*.dll and we can't guarantee that | ||
these functions will be available during JIT'ing. | ||
|
||
Differential Revision: https://reviews.llvm.org/D27296 | ||
--- | ||
lib/Target/X86/X86ISelLowering.cpp | 6 +++--- | ||
1 file changed, 3 insertions(+), 3 deletions(-) | ||
|
||
diff --git a/lib/Target/X86/X86ISelLowering.cpp b/lib/Target/X86/X86ISelLowering.cpp | ||
index 44eae35..a932792 100644 | ||
--- a/lib/Target/X86/X86ISelLowering.cpp | ||
+++ b/lib/Target/X86/X86ISelLowering.cpp | ||
@@ -2016,7 +2016,7 @@ Value *X86TargetLowering::getIRStackGuard(IRBuilder<> &IRB) const { | ||
|
||
void X86TargetLowering::insertSSPDeclarations(Module &M) const { | ||
// MSVC CRT provides functionalities for stack protection. | ||
- if (Subtarget.getTargetTriple().isOSMSVCRT()) { | ||
+ if (Subtarget.getTargetTriple().isWindowsMSVCEnvironment()) { | ||
// MSVC CRT has a global variable holding security cookie. | ||
M.getOrInsertGlobal("__security_cookie", | ||
Type::getInt8PtrTy(M.getContext())); | ||
@@ -2038,14 +2038,14 @@ void X86TargetLowering::insertSSPDeclarations(Module &M) const { | ||
|
||
Value *X86TargetLowering::getSDagStackGuard(const Module &M) const { | ||
// MSVC CRT has a global variable holding security cookie. | ||
- if (Subtarget.getTargetTriple().isOSMSVCRT()) | ||
+ if (Subtarget.getTargetTriple().isWindowsMSVCEnvironment()) | ||
return M.getGlobalVariable("__security_cookie"); | ||
return TargetLowering::getSDagStackGuard(M); | ||
} | ||
|
||
Value *X86TargetLowering::getSSPStackGuardCheck(const Module &M) const { | ||
// MSVC CRT has a function to validate security cookie. | ||
- if (Subtarget.getTargetTriple().isOSMSVCRT()) | ||
+ if (Subtarget.getTargetTriple().isWindowsMSVCEnvironment()) | ||
return M.getFunction("__security_check_cookie"); | ||
return TargetLowering::getSSPStackGuardCheck(M); | ||
} | ||
-- | ||
2.10.2 | ||
|