Quote PATH in llvm.mk for paths with spaces (JuliaLang#22705)

For windows `$$PATH` needs to be in quotes since windows paths contain spaces for bash on ubuntu on windows
antoine-levitt · Jul 16, 2017 · 30fc8e1 · 30fc8e1
1 parent 3ff6eac
commit 30fc8e1
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/deps/llvm.mk b/deps/llvm.mk
@@ -486,14 +486,14 @@ $(LLVM_BUILDDIR_withtype)/build-configured: $(LLVM_PATCH_PREV)
 $(LLVM_BUILDDIR_withtype)/build-configured: $(LLVM_SRC_DIR)/source-extracted | $(llvm_python_workaround) $(LIBCXX_DEPENDENCY)
  mkdir -p $(dir $@)
  cd $(dir $@) && \
- export PATH=$(llvm_python_workaround):$$PATH && \
+ export PATH=$(llvm_python_workaround):"$$PATH" && \
  $(CMAKE) $(LLVM_SRC_DIR) $(CMAKE_GENERATOR_COMMAND) $(CMAKE_COMMON) $(LLVM_CMAKE) \
  || { echo '*** To install a newer version of cmake, run contrib/download_cmake.sh ***' && false; }
  echo 1 > $@
 
 $(LLVM_BUILDDIR_withtype)/build-compiled: $(LLVM_BUILDDIR_withtype)/build-configured | $(llvm_python_workaround)
  cd $(LLVM_BUILDDIR_withtype) && \
- export PATH=$(llvm_python_workaround):$$PATH && \
+ export PATH=$(llvm_python_workaround):"$$PATH" && \
  $(if $(filter $(CMAKE_GENERATOR),make), \
  $(MAKE), \
  $(CMAKE) --build .)
@@ -502,7 +502,7 @@ $(LLVM_BUILDDIR_withtype)/build-compiled: $(LLVM_BUILDDIR_withtype)/build-config
 $(LLVM_BUILDDIR_withtype)/build-checked: $(LLVM_BUILDDIR_withtype)/build-compiled | $(llvm_python_workaround)
 ifeq ($(OS),$(BUILD_OS))
  cd $(LLVM_BUILDDIR_withtype) && \
- export PATH=$(llvm_python_workaround):$$PATH && \
+ export PATH=$(llvm_python_workaround):"$$PATH" && \
  $(CMAKE) --build . --target check
 endif
  echo 1 > $@