-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Targa files. #8
Conversation
* Code re-organised to allow for easier additions of new file formats. * Spaces in layer names are changed to '_' and not eaten anymore. * Script changed to run only on hitting the 'Continue' button.
* GUI definition moved to an external file 'dialog.json'; * minor clean-up in the organisation of the script
So I've reviewed this change tonight, and I'm thankful for the work. However it seem like the ability to change JPG or PNG quality not longer exists, which is a problem, as that is very necessary so I'm unable to merge these changes at the current time. |
Could you please elaborate more on this? I didn't remove any functionality. As I understand it, if you run the script and select PNG or JPG, you don't see options anymore? What version of Photoshop do you use? Anyway, this is obsolete already. I had to rewrite the script even more (actually almost all of the original code). Let me get home and push my latest changes to GitHub, then we can sit down and discuss them one by one. We can even meet on Skype to make it faster. The earliest I'll be able to attend to it is the beginning of the next week. Let's schedule a meeting then. |
Yes, I wasn't seeing the quality selector anymore or either JPG or PNG. I'm using PS CS6, I also have access to CS5 and CC. (Though I only tested your script in CS6). But I'd be more than happy to sit down with you, even on Skype. I live in Utah (the MST timezone) and get off work at 5:00PM Monday through Friday. My Skype username is the same as my Github username (if there are multiple results, it should be the one listed in Utah). |
…erged. (Indexing layers through API is very slow.)
…ance is snappier.
* Fixed restoring layer visibility for newer PS versions; reverting history trick doesn't work there.
Added support for Targa files. Cleaner and more informative UI More maintainable code
Added support for Targa files. Cleaner and more informative UI More maintainable code
Added support for Targa files. Cleaner and more informative UI More maintainable code
Added support for Targa files. Cleaner and more informative UI More maintainable code
Hi,
I've made some changes to the script and I thought others might appreciate them as well: