Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate the images with the correct size #6

Closed
wants to merge 1 commit into from

Conversation

hugozap
Copy link

@hugozap hugozap commented May 13, 2014

The images generated by the original script have the same size as the document.
This pull request fixes that so every image has the same size as its layer.

It selects the current visible layer and trims the document before saving the layer.
At the end, the original document canvas size is restored.

@antipalindrome
Copy link
Owner

I know I'm longer overdue on this, but I tested it tonight and this kind of completely destroyed my Photoshop file (it exported just fine, but after exportation all my layers are blank and the document in general is just messed out.)

So while the output is great and it doesn't slow the script down that much I really like the additions but the destructive nature of this script requires me to not merge your request.

@hugozap
Copy link
Author

hugozap commented Jun 4, 2014

Hi, yeah, i noticed that some days after sending the request
However i have already fixed it by using a temporal document to copy the layers , trimming and saving the image so the original document is never touched (not even to hide layers).

I'll try to submit a new request with those improvements, even if not merged it could still be useful for somebody.

@antipalindrome
Copy link
Owner

Great!
Well I'll be sitting down soon with another collaborator and we're going to organized and improve my script and hopefully work in some new features. If I have your updated script perhaps we can take some of your improvements and work them in as well.

Thanks.

@skjorn
Copy link
Collaborator

skjorn commented Jun 21, 2014

This is basically an implementation of #5. I'm closing it as we'll need to implement it slightly differently, although the idea is clear.

@skjorn skjorn closed this Jun 21, 2014
antipalindrome pushed a commit that referenced this pull request Sep 17, 2018
antipalindrome pushed a commit that referenced this pull request Feb 8, 2020
antipalindrome pushed a commit that referenced this pull request Feb 8, 2020
antipalindrome pushed a commit that referenced this pull request Feb 8, 2020
antipalindrome pushed a commit that referenced this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants