Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic for Batter Formatting #120

Merged
merged 4 commits into from
Sep 26, 2018
Merged

Conversation

finscn
Copy link
Contributor

@finscn finscn commented Sep 21, 2018

  • reformat the source code with js-beautify
  • add some spaces between some ui elements

No new feature , No bug fixed.

@antipalindrome
Copy link
Owner

antipalindrome commented Sep 21, 2018

@finscn it does look like a few things changed (besides formatting).

@finscn
Copy link
Contributor Author

finscn commented Sep 21, 2018

yes , I said "add some spaces between some ui elements"

{text: " "} is the spaces .

some ui elements are too closed , the spaces could make them be more clear.

@antipalindrome
Copy link
Owner

When I try and run this script I'm getting: Error: ReferenceError: cbBgLayer is undefined which I assume is coming from the fact that this attribute is now wrapped in a new element. Are there other changes you forgot to include in this pull request?

grpBgFgLayer is parent of cbBgLayer/cbFgLayer
@finscn
Copy link
Contributor Author

finscn commented Sep 25, 2018

sorry , it's my fault. I've updated the file. Could you test again ?

@antipalindrome antipalindrome merged commit fc62bb7 into antipalindrome:master Sep 26, 2018
@antipalindrome
Copy link
Owner

Looks all good, thanks @finscn

antipalindrome pushed a commit that referenced this pull request Feb 8, 2020
Cosmetic changes, better dialog formatting
antipalindrome pushed a commit that referenced this pull request Feb 8, 2020
Cosmetic changes, better dialog formatting
antipalindrome pushed a commit that referenced this pull request Feb 8, 2020
Cosmetic changes, better dialog formatting
antipalindrome pushed a commit that referenced this pull request Jan 4, 2022
Cosmetic changes, better dialog formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants