Multiple Features - Implements old requests/issues #118
Conversation
…ers-as-Images into jgod-ignore-layers-starting-with-bang
Finscn groups to layers
…ing-with-bang' into integration # Conflicts: # Export Layers To Files (Fast).jsx
# Conflicts: # Export Layers To Files (Fast)-dialog.json # Export Layers To Files (Fast).jsx
# Conflicts: # Export Layers To Files (Fast).jsx
# Conflicts: # Export Layers To Files (Fast)-dialog.json # Export Layers To Files (Fast).jsx
|
WOW , great job. But I found there are some mistakes of my fork in new PS CC. |
|
I started by merging your code (using your master branch). |
|
@Willena This all sounds very great! I'm very glad you were able to address a lot of these issues. I wish I had had more time to do some of this myself as well. I will try to test these features, and make sure performance for the base-case is still as fast as it was before and if everything looks good I will merge it into master. :) |
|
@Willena The new features see to work really great for the most part. I did find one issue, in Photoshop CC 2018 when I use "Top groups as layers" I get the error Further, even with default settings (not using any new features) when I run this script compared to the current live version, the script take on average 1.6 seconds longer (or ~17%) on export (with my test file, which is relatively small). So I'm wondering if it runs a lot of extra logic now that it might not need to? Other than that though this works wonderfully. If you could review the error, and see if there's anything to be done about the performance slow down that'd be great. Thanks! |
|
the feature "Top groups as layers" is created by me. I'll try to fix this bug.
|
|
@Willena, I've fixed the bug. (the reason is I've committed the code to https://github.com/finscn/Photoshop-Export-Layers-to-Files-Fast @Willena , could you merge it to this PR ? |
if the group is empty , don't call merge()
|
@finscn I've merged your commit. @hsw107 Can you do some new testing with the fix ? I'll try to find what causes the script to be a little longer, and make some changes if necessary. |
|
Thanks @finscn. I will retest it soon! |
|
Excellent! Just excellent! Good Job! Definitely one of the best plug-ins for PS. |
|
@Willena All done :) Thanks again! |
|
Thanks so much for this changes. |
|
I think #56 can also be closed. If I understand it correctly, trimming wider than the layer can be done with the padding functionality (a padding value of 1px or 2px). Am I right ? |
|
@Willena I did miss that, thanks! And yeah, I cleaned up all the issues so they should be easier to read through. |
|
@Willena I've updated my code for cosmetic . Could you create a new PR? |
|
@finscn Have you looked through here? |
Multiple Features - Implements old requests/issues
Multiple Features - Implements old requests/issues
Multiple Features - Implements old requests/issues
Multiple Features - Implements old requests/issues
In this pull request you will find a set of new features.
From old issues:
Ability to ignore layer starting with an "exclude string" (implemented by @jgod, improved by me; Related subbranch : https://github.com/Willena/Photoshop-Export-Layers-to-Files-Fast/tree/jgod-ignore-layers-starting-with-bang)
Similar to the background feature, it is now possible to keep the highest layer on top of all other layer when exporting. (Related issues : No Pin Layers on Top... No Merge Groups as Image #108, Highest layer repeated on each exported layer #96, creating constant layers #42; Related subbranch : https://github.com/Willena/Photoshop-Export-Layers-to-Files-Fast/tree/first-layer-as-foreground)
Groups can now be exported as a single image/layer. (implemented by @finscn, updated to be mergeable by me) ( related issues : How to save layers in a group as a single image while using this script? #79 My Fork's new Feature : Export Top Groups as Layers #70 how about exports based on layer groups? #69 I add a new feature : Export Top-Group as Layer #21 No Pin Layers on Top... No Merge Groups as Image #108 ; Related subbranch : https://github.com/Willena/Photoshop-Export-Layers-to-Files-Fast/tree/finscn-groups-to-layers)
Add Transparent padding pixels before export (Related issue : Feature Request: Limit Trim/Add Transparency/Padding #64 ; Related subbranch : https://github.com/Willena/Photoshop-Export-Layers-to-Files-Fast/tree/transparent-padding-pixels)
New Features :
Here is a screenshot of the UI with new parameters:
Feel free to comment and test my work.