Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added file output suffix functionality #103

Merged
merged 2 commits into from
Apr 16, 2017

Conversation

crtgregoric
Copy link
Contributor

No description provided.

@skjorn
Copy link
Collaborator

skjorn commented Apr 16, 2017

Hi, thank you very much for your addition! I modified the layout of the dialog a bit and fixed the space to be added before the suffix, not after. Would you be so kind to check my modifications (files attached below) against your submitted version, apply them and re-submit your pull request again? I'll be happy to merge it. (Sorry, had to rename the files to .txt for GitHub to accept them.)

dialog.json.txt
Export Layers To Files (Fast).jsx.txt

@crtgregoric
Copy link
Contributor Author

crtgregoric commented Apr 16, 2017

I have reviewed your changes and looks good to me.
The new layout is much better.
As for the spaces, in my testing no spaces were added (which suits my needs), so not really sure what should it do (should the output file be named "{prefix} name {suffix}"?).

@skjorn
Copy link
Collaborator

skjorn commented Apr 16, 2017

Basically, it adds the spaces (as you mentioned it becomes "{prefix} name {suffix}") and then converts them to '_' if "Allow spaces" is not set, so this should be fine.

Thanks, I'll merge it then.

@skjorn skjorn merged commit 715ccf8 into antipalindrome:master Apr 16, 2017
antipalindrome pushed a commit that referenced this pull request Feb 8, 2020
Added file output suffix functionality
antipalindrome pushed a commit that referenced this pull request Feb 8, 2020
Added file output suffix functionality
antipalindrome pushed a commit that referenced this pull request Jan 4, 2022
Added file output suffix functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants