Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to files with cache busting suffix #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abdoIO
Copy link

@abdoIO abdoIO commented Apr 30, 2020

Files that look like main.css?t=123456 cause error since cache busting suffix is not supported. These changes added support to these kind of files.

@thescientist13
Copy link
Collaborator

thescientist13 commented May 3, 2020

Thanks for the PR @abdoIO 👍

Could you provide the error that you saw? Just curious and then all it can be a good reference for anyone else who comes across this issue.

@abdoIO
Copy link
Author

abdoIO commented May 4, 2020

@thescientist13 Thank you for your prompt response.

Here is the error log
[ERROR] Error: css should not be empty [ERROR] at <node_modules/penthouse/lib/index.js>:220:33 [ERROR] at Generator.next (<anonymous>) [ERROR] at step (<node_modules/penthouse/lib/index.js>:19:191) [ERROR] at <node_modules/penthouse/lib/index.js>:19:437 [ERROR] at new Promise (<anonymous>) [ERROR] at <node_modules/penthouse/lib/index.js>:19:99 [ERROR] at Promise (<node_modules/penthouse/lib/index.js>:241:20) [ERROR] at new Promise (<anonymous>) [ERROR] at module.exports (<node_modules/penthouse/lib/index.js>:182:10) [ERROR] at <node_modules/critical/lib/core.js>:191:16 [ERROR] at tryCatcher (<node_modules/bluebird/js/release/util.js>:16:23) [ERROR] at Promise._settlePromiseFromHandler (<node_modules/bluebird/js/release/promise.js>:517:31) [ERROR] at Promise._settlePromise (<node_modules/bluebird/js/release/promise.js>:574:18) [ERROR] at Promise._settlePromise0 (<node_modules/bluebird/js/release/promise.js>:619:10) [ERROR] at Promise._settlePromises (<node_modules/bluebird/js/release/promise.js>:699:18) [ERROR] at Promise._fulfill (<node_modules/bluebird/js/release/promise.js>:643:18) [ERROR] at Promise._resolveCallback (<node_modules/bluebird/js/release/promise.js>:437:57) [ERROR] at Promise._settlePromiseFromHandler (<node_modules/bluebird/js/release/promise.js>:529:17) [ERROR] at Promise._settlePromise (<node_modules/bluebird/js/release/promise.js>:574:18) [ERROR] at Promise._settlePromise0 (<node_modules/bluebird/js/release/promise.js>:619:10) [ERROR] at Promise._settlePromises (<node_modules/bluebird/js/release/promise.js>:699:18) [ERROR] at Promise._fulfill (<node_modules/bluebird/js/release/promise.js>:643:18) [ERROR] at Promise._resolveCallback (<node_modules/bluebird/js/release/promise.js>:459:14) [ERROR] at ReductionPromiseArray._resolve (<node_modules/bluebird/js/release/reduce.js>:61:19) [ERROR] at ReductionPromiseArray._resolveEmptyArray (<node_modules/bluebird/js/release/reduce.js>:52:10) [ERROR] at ReductionPromiseArray.init (<node_modules/bluebird/js/release/promise_array.js>:71:18) [ERROR] at Promise._settlePromise (<node_modules/bluebird/js/release/promise.js>:571:21) [ERROR] at Promise._settlePromise0 (<node_modules/bluebird/js/release/promise.js>:619:10) [ERROR] at Promise._settlePromises (<node_modules/bluebird/js/release/promise.js>:699:18) [ERROR] at _drainQueueStep (<node_modules/bluebird/js/release/async.js>:138:12) [ERROR] at _drainQueue (<node_modules/bluebird/js/release/async.js>:131:9) [ERROR] at Async._drainQueues (<node_modules/bluebird/js/release/async.js>:147:5) [ERROR] at Immediate.Async.drainQueues (<node_modules/bluebird/js/release/async.js>:17:14) [ERROR] at runCallback (timers.js:705:18) [ERROR] at tryOnImmediate (timers.js:676:5) [ERROR] at processImmediate (timers.js:658:5)

Copy link
Collaborator

@thescientist13 thescientist13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thoughts @anthonygore ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants