Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pagination support disabled prop #16493

Merged
merged 6 commits into from
May 10, 2019
Merged

feat: Pagination support disabled prop #16493

merged 6 commits into from
May 10, 2019

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented May 9, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

👻 What's the background?

close #15986

💡 Solution

Update rc-pagination

📝 Changelog

Pagination support disabled prop

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/pagination/index.en-US.md
View rendered components/pagination/index.zh-CN.md

@netlify
Copy link

netlify bot commented May 9, 2019

Deploy preview for ant-design ready!

Built with commit 16431c5

https://deploy-preview-16493--ant-design.netlify.com

@buildsize
Copy link

buildsize bot commented May 9, 2019

File name Previous Size New Size Change
package-lock.json 819.41 KB 820.57 KB 1.15 KB (0%)

@netlify
Copy link

netlify bot commented May 9, 2019

Deploy preview for ant-design ready!

Built with commit fda7f0a

https://deploy-preview-16493--ant-design.netlify.com

@codecov
Copy link

codecov bot commented May 9, 2019

Codecov Report

Merging #16493 into feature will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #16493   +/-   ##
========================================
  Coverage    95.65%   95.65%           
========================================
  Files          258      258           
  Lines         7107     7107           
  Branches      2004     1968   -36     
========================================
  Hits          6798     6798           
  Misses         307      307           
  Partials         2        2
Impacted Files Coverage Δ
components/pagination/Pagination.tsx 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 108caa2...fda7f0a. Read the comment docs.

@zombieJ
Copy link
Member Author

zombieJ commented May 9, 2019

箭头 disabled 的样式有点问题。

内部按钮的 disabled className 也叫 ant-pagination-disabled,郁闷……

@zombieJ
Copy link
Member Author

zombieJ commented May 9, 2019

Update. Please check again.

Disabled shapshot:
屏幕快照 2019-05-09 下午4 11 49

@afc163
Copy link
Member

afc163 commented May 9, 2019

来个 disabled 的例子吧。

@afc163
Copy link
Member

afc163 commented May 9, 2019

图片

这样好了,或者找下设计师。

  • 数字色:rgba(0, 0, 0, .25)
  • 背景色:#f5f5f5
  • 当前背景色:#d9d9d9

@zombieJ
Copy link
Member Author

zombieJ commented May 10, 2019

@afc163
Copy link
Member

afc163 commented May 10, 2019

字色改成:color: rgba(0,0,0, .25); 吧。

@zombieJ zombieJ merged commit e88589d into feature May 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the pagination-disabled branch May 10, 2019 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants