Fix spin delay issue if mounts with spinning=true #10727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ant-design ready! Built with commit 2ea8998 |
Codecov Report
@@ Coverage Diff @@
## master #10727 +/- ##
==========================================
+ Coverage 91.52% 91.58% +0.05%
==========================================
Files 194 194
Lines 4743 4764 +21
Branches 1322 1329 +7
==========================================
+ Hits 4341 4363 +22
+ Misses 398 397 -1
Partials 4 4
Continue to review full report at Codecov.
|
|
@dreamerblue Could you add a test case? |
|
@yesmeck OK, I have added a test case. |
yesmeck
reviewed
Jun 2, 2018
components/spin/index.tsx
Outdated
| @@ -56,6 +56,14 @@ export default class Spin extends React.Component<SpinProps, SpinState> { | |||
| return !!(this.props && this.props.children); | |||
| } | |||
|
|
|||
| componentWillMount() { | |||
There was a problem hiding this comment.
Can we use componentDidMount? Because componentWillMount will be marked as unsafe in the feature versions of react.
There was a problem hiding this comment.
Forgot to reply there. The method has been changed to "componentDidMount".
|
@yesmeck Thanks for your suggestion. I have changed the method and tested it again. |
|
CI failed |
|
@yesmeck At previous commit e813024 I passed CI. I really don't know why it failed. Or can you try to rebuild CI? |
bors bot
added a commit
to mozilla/delivery-console
that referenced
this pull request
Jun 11, 2018
189: Update dependency antd to v3.6.2 r=rehandalal a=renovate[bot] This Pull Request updates dependency [antd](https://github.com/ant-design/ant-design) from `v3.6.1` to `v3.6.2` <details> <summary>Release Notes</summary> ### [`v3.6.2`](https://github.com/ant-design/ant-design/releases/3.6.2) [Compare Source](ant-design/ant-design@70ca028...3.6.2) - 🐞 Fix the wrong status of check all checkbox in Table when data change. [#​10629](`ant-design/ant-design#10629) - 🐞 Fix border style of Button.Group. - 🐞 Fix file list being reversed when `beforeUpload` returns `false` in Upload component. [#​10681](`ant-design/ant-design#10681) - 🐞 Fix overflow of cell content in Calendar. [#​10808](`ant-design/ant-design#10808) [@​Yangzhedi](https://github.com/ant-design/Yangzhedi) - 🐞 Fix the processing color of Badge not follows the `primary-color`. - Spin - 🐞 Fix custom icon does not follow the value of `size`. [#​10786](`ant-design/ant-design#10786) - 🐞 Fix no `delay` issue when sets `spinning` to `true` as default.[#​10727](`ant-design/ant-design#10727) [@​dreamerblue] - TypeScript - 🐞 Fix Menu type definition. [#​10773](`ant-design/ant-design#10773) - 🐞 Fix AutoComplete type definition. [#​10745](`ant-design/ant-design#10745) [#​10619](`ant-design/ant-design#10619) - 🐞 Fix Tree type definition. [#​10841](`ant-design/ant-design#10841) [@​Voronar] - 🐞 Fix Checkbox.Group definition. [#​10677](`ant-design/ant-design#10677) --- - 🐞 修复 Table 数据变化时全选勾选框状态显示不正确的问题。[#​10629](`ant-design/ant-design#10629) - 🐞 修复 Button.Group 中使用 disabled 按钮时缺失边框。 - 🐞 修复 Upload 中 `beforeUpload` 返回 `false` 时，文件列表排序会被反转的问题。[#​10681](`ant-design/ant-design#10681) - 🐞 修复 Calendar 表格中内容溢出的问题。[#​10808](`ant-design/ant-design#10808) [@​Yangzhedi](https://github.com/ant-design/Yangzhedi) - Spin - 🐞 修复使用图标时不能按照 `size` 正确显示大小的问题。[#​10786](`ant-design/ant-design#10786) - 🐞 修复默认旋转时 `delay` 不生效的问题。[#​10727](`ant-design/ant-design#10727) [@​dreamerblue] - 修复 Badge 的状态色不跟主题色变化的问题。 - TypeScript - 🐞 修复 Menu 类型定义。[#​10773](`ant-design/ant-design#10773) - 🐞 修复 AutoComplete 类型定义。[#​10745](`ant-design/ant-design#10745) [#​10619](`ant-design/ant-design#10619) - 🐞 修复 Tree 类型定义。[#​10841](`ant-design/ant-design#10841) [@​Voronar] - 🐞 修复 Checkbox.Group 的类型定义。[#​10677](`ant-design/ant-design#10677) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com). Co-authored-by: Renovate Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
master, feature for latest active branchfeature-x.x.npm run lintand fix those errors before submitting in order to keep consistent code style.Extra checklist:
if isBugFix :
If a spin component mounts with spinning=true and delay (e.g. in case of rendering a component with data loading initially), it won't be delayed. This PR just fix for it.