Support linked_clone for Vagrant 2.X #1085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for vagrant 2.X
|
Please correct the commit message so it has a descriptive commit message in the subject and body. |
retr0h
reviewed
Jan 9, 2018
| if Vagrant::VERSION =~ /^1.[89]/ | ||
| virtualbox.linked_clone = provider['options']['linked_clone'] | ||
| end | ||
| virtualbox.linked_clone = provider['options']['linked_clone'] if Gem::Version.new(Vagrant::VERSION) >= Gem::Version.new('1.8.0') |
There was a problem hiding this comment.
While I understand this is a more ruby way of doing things with the one line setting of a conditional var, it will exceed the project line length limit. Please use the Gem version comparison, but keep the conditional on a separate line.
retr0h
reviewed
Jan 9, 2018
| if Vagrant::VERSION =~ /^1.[89]/ | ||
| virtualbox.linked_clone = true | ||
| end | ||
| virtualbox.linked_clone = true if Gem::Version.new(Vagrant::VERSION) >= Gem::Version.new('1.8.0') |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for vagrant 2.X resolves the #1084