Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid invalid group characters in default inventory script factory #8617

Merged
merged 1 commit into from
Nov 18, 2020
Merged

Avoid invalid group characters in default inventory script factory #8617

merged 1 commit into from
Nov 18, 2020

Conversation

AlanCoding
Copy link
Member

SUMMARY

This avoids the warning:

[WARNING]: Invalid characters were found in group names but not replaced, use

When this script is used.

Pretty soon, we need to kill off this script, but we also need to silence this warning to clean up some tests right now.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
  • API

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@jladdjr
Copy link
Contributor

jladdjr commented Nov 18, 2020

@AlanCoding - I think we can merge this one if you're ready

@AlanCoding
Copy link
Member Author

We only have 1 test change needed where it hard-coded "group-" and we just change that to "group_"

I'll see about getting that change in and merging this.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit f22fa9c into ansible:devel Nov 18, 2020
@AlanCoding AlanCoding deleted the valid_groups branch September 8, 2021 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jladdjr jladdjr jladdjr approved these changes

Assignees
No one assigned
Labels
component:cli
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlanCoding @jladdjr