Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds workflow approval list and details #8375

Merged
merged 13 commits into from
Nov 25, 2020
Merged

Adds workflow approval list and details #8375

merged 13 commits into from
Nov 25, 2020

Commits on Nov 17, 2020

  1. Adds /#/workflow_approvals list and details and allows users to appro… 

    …ve or deny workflow approvals from these interfaces
    @mabashian
    mabashian committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    ee7f736 View commit details
    Browse the repository at this point in the history

  2. Move approval action buttons from rows to to level list actions. UX u… 

    …pdates to the display of the status.
    @mabashian
    mabashian committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    a9c3484 View commit details
    Browse the repository at this point in the history

  3. Combine approve/deny modals into one modal

    @mabashian
    mabashian committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    aba14bf View commit details
    Browse the repository at this point in the history

  4. Remove old TODO

    @mabashian
    mabashian committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    2be5ae3 View commit details
    Browse the repository at this point in the history

  5. Move all mock workflow approvals out to data.workflowApprovals.json

    @mabashian
    mabashian committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    929be16 View commit details
    Browse the repository at this point in the history

  6. Prevent users from attempting to delete pending approvals

    @mabashian
    mabashian committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    b8b3424 View commit details
    Browse the repository at this point in the history

  7. Fix basic name filtering on workflow approvals list

    @mabashian
    mabashian committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    30e461c View commit details
    Browse the repository at this point in the history

  8. Add description to the list of default search keys on workflow approv… 

    …als list
    @mabashian
    mabashian committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    ebf9bf4 View commit details
    Browse the repository at this point in the history

  9. Show 'Deleted' when the source workflow job is deleted in workflow ap… 

    …provals list/details
    @mabashian
    mabashian committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    a4e4f0a View commit details
    Browse the repository at this point in the history

  10. Adds data-cy attributes to the fields in the workflow approval details

    @mabashian
    mabashian committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    8c263f1 View commit details
    Browse the repository at this point in the history

  11. Hide the delete button on workflow approval details when job is pending

    @mabashian
    mabashian committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    8cd4d06 View commit details
    Browse the repository at this point in the history

  12. Update snapshot after adding cannotDelete prop to ToolbarDeleteButton

    @mabashian
    mabashian committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    76c39e3 View commit details
    Browse the repository at this point in the history

  13. Wrap status label in a div so that it doesn't vertically stretch with… 

    … it's parent.
    @mabashian
    mabashian committed Nov 17, 2020
    Configuration menu
    Copy the full SHA
    ef1da5d View commit details
    Browse the repository at this point in the history