Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to the latest version of ansible-runner #6394

Merged
merged 1 commit into from
Mar 24, 2020
Merged

update to the latest version of ansible-runner #6394

merged 1 commit into from
Mar 24, 2020

Conversation

ryanpetrello
Copy link
Contributor

No description provided.

ryanpetrello
ryanpetrello commented Mar 24, 2020
View reviewed changes
requirements/requirements.txt
@@ -1,48 +1,48 @@
adal==1.2.2 # via msrestazure
aiohttp==3.6.2
aiohttp==3.6.2 # via -r /awx_devel/requirements/requirements.in
Copy link
Contributor Author

@ryanpetrello ryanpetrello Mar 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost none of this (other than the runner version) represents an actual change; it's just a change in the way the tooling generates comments now cc @AlanCoding.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this still doesn't apply the change to requirements_ansible.txt

I'm fully in favor of applying this, it's an intended improvement.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@ryanpetrello
Copy link
Contributor Author

running through some integration before merging this

@AlanCoding
Copy link
Member

https://github.com/ansible/ansible-runner/blob/devel/CHANGES.rst

1.4.5 (2020-03-19)
Fix an issue with --process_isoloation_*_ paths parsing cli args
Switch default docker images to centos:8
Switch extravar format so we can support more than just string types
Make sure job events folder is created earlier to prevent errors when using immediately after starting a runner job
Annotate all runner_on events with start/end/duration times

ryanpetrello
ryanpetrello commented Mar 24, 2020
View reviewed changes
requirements/requirements_ansible.txt
@@ -1,46 +1,46 @@
adal==1.2.2 # via msrestazure
apache-libcloud==2.5.0
apache-libcloud==2.5.0 # via -r /awx_devel/requirements/requirements_ansible.in
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @AlanCoding

@ryanpetrello
Copy link
Contributor Author

@wenottingham do you have some AWX issue I don't know about to track this work?

ansible/ansible-runner#405

@jakemcdermott
Copy link
Contributor

recheck

@ryanpetrello ryanpetrello reopened this Mar 24, 2020
@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded.

@softwarefactory-project-zuul
Copy link
Contributor

Build succeeded (gate pipeline).

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit cbc02dd into ansible:devel Mar 24, 2020
@wenottingham
Copy link
Contributor

@wenottingham do you have some AWX issue I don't know about to track this work?

ansible/ansible-runner#405

It's for analytics usage (tracking task timings, which only existed for a subset of modules beforehand.0

AlanCoding pushed a commit to AlanCoding/awx that referenced this pull request Jun 5, 2023
@relrod
Rename heartbeet daemon to ws_heartbeat (ansible#14041) (ansible#6394)
64e6572 
Signed-off-by: Rick Elrod <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spredzy Spredzy Spredzy approved these changes

@AlanCoding AlanCoding AlanCoding approved these changes

@matburt matburt Awaiting requested review from matburt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ryanpetrello @AlanCoding @jakemcdermott @wenottingham @Spredzy