Fix cancel bug - WorkflowManager cancel in transaction #14608
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Describing the bug here, I have not seen it in the issue queue:
I was able to see the real bug with manual testing:
Expectation is that JT will be canceled. It temporarily gets the "canceled" status (which is incorrect) and then it goes into "successful" status. This is a bug, where workflows run out the clock on jobs running inside that workflow.
I can verify this fixes it. This change makes the cancel message fire as part of the task manager transaction - similar to the messages that tell the dispatcher to start a new job.
ISSUE TYPE
COMPONENT NAME