-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix extra_vars bug in ansible.controller.ad_hoc_command #14585
Merged
jessicamack
merged 6 commits into
ansible:devel
from
jessicamack:accept-adhoc-extra-vars
Oct 25, 2023
Merged
Fix extra_vars bug in ansible.controller.ad_hoc_command #14585
jessicamack
merged 6 commits into
ansible:devel
from
jessicamack:accept-adhoc-extra-vars
Oct 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
github-actions
bot
added
the
component:awx_collection
issues related to the collection for controlling AWX
label
Oct 19, 2023
AlanCoding
reviewed
Oct 20, 2023
Signed-off-by: jessicamack <[email protected]>
Signed-off-by: jessicamack <[email protected]>
confirmed that the new test is being ran in the CI and passes |
TheRealHaoLiu
approved these changes
Oct 25, 2023
11 tasks
djyasin
pushed a commit
to djyasin/awx
that referenced
this pull request
Sep 16, 2024
* convert to valid type for serializer * check that extra_vars are in request * remove doubled line * add integration test for change * move change to the ad_hoc_command module Signed-off-by: jessicamack <[email protected]> * fix imports Signed-off-by: jessicamack <[email protected]> --------- Signed-off-by: jessicamack <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Related #14481
We're currently submitting an OrderedDict to a CharField which is throwing a validation error on the serializer.
This PR converts the OrderedDict to a JSON string before submitting it.
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION
Before
After