Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dockerfile #15

Merged
merged 8 commits into from
Mar 4, 2023
Merged

add dockerfile #15

merged 8 commits into from
Mar 4, 2023

Conversation

Robin021
Copy link
Contributor

@Robin021 Robin021 commented Mar 2, 2023

No description provided.

@vercel
Copy link

vercel bot commented Mar 2, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @ddiu8081 on Vercel.

@ddiu8081 first needs to authorize it.

@ddiu8081
Copy link
Member

ddiu8081 commented Mar 2, 2023

Thanks! I'm totally new to Docker, but I think you're doing the right thing!

I'm still working on a few things and will merge it soon.

@quzard
Copy link
Contributor

quzard commented Mar 2, 2023

I think the Dockerfile should be modified to look like this, because if the host is not specified, the internal services in Docker will only listen on localhost and cannot be mapped outside.

FROM node:alpine
RUN mkdir -p /usr/src
WORKDIR /usr/src
COPY . /usr/src
RUN npm install
EXPOSE 3000
CMD npm run start -- --port 3000 --host 0.0.0.0

quzard and others added 4 commits March 3, 2023 00:12
I think the Dockerfile should be modified to look like this, because if the host is not specified, the internal services in Docker will only listen on localhost and cannot be mapped outside.
@ddiu8081 ddiu8081 merged commit 25591a0 into anse-app:main Mar 4, 2023
@ddiu8081 ddiu8081 mentioned this pull request Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants