use innerText to escape htmlString when showRawCode is on #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #26
Linked Issues
fix #26
Additional context
I have to add a
getClass()
function to retain reactivity:export default (props: Props) => { const htmlString = () => props.showRawCode ? props.text : parseMarkdown(props.text) + const getClass = () => `${props.class ?? ''} ${props.showRawCode ? 'whitespace-pre-wrap overflow-auto my-0' : ''}` return props.showRawCode ? <div class={getClass()} innerText={htmlString()} /> : <div class={getClass()} innerHTML={htmlString()} /> }
or I have to write it twice, which is more repetitive:
I wonder if there is a way to implement it more elegantly.