Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing call to cpuid_set_error #202

Closed
wants to merge 1 commit into from

Conversation

zacikpa
Copy link
Contributor

@zacikpa zacikpa commented Jul 16, 2024

Forgotten during c5d9b38.

@TheTumultuousUnicornOfDarkness
Copy link
Collaborator

TheTumultuousUnicornOfDarkness commented Jul 26, 2024

It was not forgotten: it serves a purpose in cpuid_get_all_raw_data().

cur_error = cpuid_get_raw_data_core(&raw_tmp, logical_cpu);
if (cur_error == ERR_INVCNB)
	break;

The logic is to break the loop when the affinity cannot be set, i.e. when the core number does not exist.
But cpuid_get_raw_data_core() is a public function and you are right: it should be improved. I will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants