Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: improve tx dump / tx sign #3648

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

Fraccaman
Copy link
Member

@Fraccaman Fraccaman commented Aug 14, 2024

Describe your changes

Closes #3417.

Checklist before merging

  • If this PR has some consensus breaking changes, I added the corresponding breaking:: labels
    • This will require 2 reviewers to approve the changes

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 3.61446% with 80 lines in your changes missing coverage. Please review.

Project coverage is 61.21%. Comparing base (4cd4356) to head (b673111).
Report is 37 commits behind head on main.

Files Patch % Lines
crates/tx/src/lib.rs 0.00% 35 Missing ⚠️
crates/core/src/hash.rs 0.00% 31 Missing ⚠️
crates/sdk/src/tx.rs 0.00% 10 Missing ⚠️
crates/sdk/src/signing.rs 0.00% 2 Missing ⚠️
crates/tx/src/types.rs 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3648      +/-   ##
==========================================
- Coverage   61.24%   61.21%   -0.03%     
==========================================
  Files         312      312              
  Lines      101374   101430      +56     
==========================================
+ Hits        62086    62090       +4     
- Misses      39288    39340      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dump-tx invalid serialization
1 participant