Support only a transparent address as a refund target #3646
Conversation
|
hmm, wasm compilation error happened again on my Mac |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3646 +/- ##
==========================================
+ Coverage 61.18% 61.20% +0.01%
==========================================
Files 312 312
Lines 101384 101356 -28
==========================================
- Hits 62033 62031 -2
+ Misses 39351 39325 -26 ☔ View full report in Codecov by Sentry. |
yito88
force-pushed
the
yuji/ibc-refund-transparent
branch
from
bbcfc57
to
db26e06
Compare
crates/sdk/src/tx.rs
Outdated
| let mut wallet = context.wallet_mut().await; | ||
| if let Some(addr) = wallet.find_address(IBC_REFUND_TARGET_ALIAS) { |
There was a problem hiding this comment.
I believe it's better to generate a new disposable address every time, otherwise we might establish some linkage between the shielded ibc operations and this transparent refund address
There was a problem hiding this comment.
That's a default one. A user can prepare an address and set it with --refund-target.
There was a problem hiding this comment.
But yes, it's better to generate a new one for useability
| @@ -28,6 +28,7 @@ where | |||
| C: IbcCommonContext, | |||
| { | |||
| inner: Rc<RefCell<C>>, | |||
| is_shielded: bool, | |||
There was a problem hiding this comment.
Why do we have this new field?
There was a problem hiding this comment.
Because the sender in the IBC packet is replaced with the refund address. The context doesn't know whether the sender is the actual sender or the refund target.
Describe your changes
Closes #3620
Checklist before merging
breaking::labels