Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft+3502 #3524

Closed
wants to merge 88 commits into from
Closed

Draft+3502 #3524

wants to merge 88 commits into from

Conversation

brentstone
Copy link
Contributor

Describe your changes

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

sug0 and others added 28 commits July 15, 2024 12:36
* yuji/tendermint-0.37:
  add changelog
  update ibc-derive
  tower-abci 0.15.0
  update tendermint-rs to 0.37
* tiago/masp-ss-client-phase-1:
  Changelog for #3498
  Document origin of obfuscated/opaque masp tx
  Implement a gnarly cross-platform logging iterator
  Implement phase 1 of shielded sync
* tiago/masp-ss-phase-2:
  Changelog for #3456
  Remove `ThenAwait` abstraction
  Remove default methods from masp client trait
  Deserialize server err response from masp indexer client
  More misc masp indexer client fixes
  Fetch indexed txs in batches of the max req thres
  Inline caps in masp client
  Misc indexer client fixes
  Fetch masp pre-built data during shielded sync
  Integrate indexer client with the CLI
  Advance peek iterator at the top of loop
  Optionally trigger witness map update
  Implement a masp client backed by the `namada-masp-indexer`
  Decouple ledger rpc client from masp client
  Remove batch size arg
  Update `reqwest`
  Disable building ledger masp client on wasm targets
  Make masp client caps a default method
  Add new fetch methods to masp client trait
  Emit spin loop hint on masp txs receiver
  Always retry from the latest synced height during ss
  Use `BlockHeight` instead of `u64` in fetch args
  Define capabilities for masp rpc clients
* murisi/without-pow:
  changelog: add #3502
  Removed redundant build_pow_flag function.
Copy link

codecov bot commented Jul 17, 2024

Codecov Report

Attention: Patch coverage is 43.15280% with 1291 lines in your changes missing coverage. Please review.

Project coverage is 53.69%. Comparing base (8479d38) to head (b5b4611).
Report is 4 commits behind head on main.

Files Patch % Lines
crates/sdk/src/masp/utils.rs 4.55% 356 Missing ⚠️
crates/sdk/src/signing.rs 0.00% 271 Missing ⚠️
crates/apps_lib/src/client/masp.rs 0.00% 134 Missing ⚠️
crates/sdk/src/masp.rs 86.08% 107 Missing ⚠️
crates/node/src/shims/abcipp_shim_types.rs 0.00% 78 Missing ⚠️
crates/node/src/shims/abcipp_shim.rs 0.00% 72 Missing ⚠️
crates/sdk/src/masp/test_utils.rs 70.54% 43 Missing ⚠️
crates/namada/src/ledger/protocol/mod.rs 54.87% 37 Missing ⚠️
crates/node/src/lib.rs 0.00% 36 Missing ⚠️
crates/ibc/src/msg.rs 0.00% 24 Missing ⚠️
... and 24 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3524      +/-   ##
==========================================
+ Coverage   53.48%   53.69%   +0.20%     
==========================================
  Files         320      322       +2     
  Lines      110000   111746    +1746     
==========================================
+ Hits        58832    59999    +1167     
- Misses      51168    51747     +579     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentstone brentstone closed this Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants