-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Streamline validation #3448
Streamline validation #3448
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3448 +/- ##
==========================================
- Coverage 53.92% 53.87% -0.05%
==========================================
Files 317 317
Lines 107575 107664 +89
==========================================
- Hits 58011 58007 -4
- Misses 49564 49657 +93 ☔ View full report in Codecov by Sentry. |
NOTE: currently, the recheck is done calling I'll try to address both of these in another branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 small style recommendation - other than that LGTM
* grarco/streamline-validation: Refactors recheck of `process_proposal` before `finalize_block` Changelog #3448 Clippy + fmt Removes redundant check in `finalize_block` and implements recheck Updates docs of `finalize_block` and `process_proposal` Moves allowed txs check in `process_proposal` before the check on fees Removes duplicated validation in `prepare_proposal` Anticipates check on tx allowlist in mempool Changelog #3192 Minor code optimizations
* grarco/streamline-validation: Refactors recheck of `process_proposal` before `finalize_block` Changelog #3448 Clippy + fmt Removes redundant check in `finalize_block` and implements recheck Updates docs of `finalize_block` and `process_proposal` Moves allowed txs check in `process_proposal` before the check on fees Removes duplicated validation in `prepare_proposal` Anticipates check on tx allowlist in mempool
* origin/grarco/streamline-validation: Refactors recheck of `process_proposal` before `finalize_block` Changelog #3448 Clippy + fmt Removes redundant check in `finalize_block` and implements recheck Updates docs of `finalize_block` and `process_proposal` Moves allowed txs check in `process_proposal` before the check on fees Removes duplicated validation in `prepare_proposal` Anticipates check on tx allowlist in mempool
Describe your changes
Closes #3190.
Closes #3193.
This PR fixes some wrong documentation for the
finalize_block
andcheck_proposal_tx_function
.It also introduces a new local configuration parameter to allows a node to rerun the
process_proposal
checks before finalize block in case they don't want to blindly trust the majority of validators. This is implemented for both full nodes and validators since the latter could also skip theprocess_proposal
call in some cases.Indicate on which release or other PRs this topic is based on
#3192 (diffs for review: https://github.com/anoma/namada/pull/3448/files/176754fbd523ec7d17a1dbbd10f59900b846aeb1..1a704b679b122656aa4ff6d0baa947054c326271)
Checklist before merging to
draft