Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

governance: remove epoch multipler check #3390

Merged
merged 5 commits into from
Jul 5, 2024

Conversation

Fraccaman
Copy link
Member

@Fraccaman Fraccaman commented Jun 7, 2024

Describe your changes

Closes #3388

Indicate on which release or other PRs this topic is based on

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@Fraccaman Fraccaman changed the title remove epoch multipler check for governance governance: remove epoch multipler check Jun 7, 2024
@brentstone brentstone mentioned this pull request Jun 7, 2024
Copy link

codecov bot commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.04%. Comparing base (883bd0f) to head (04ac10e).
Report is 83 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3390      +/-   ##
==========================================
- Coverage   54.05%   54.04%   -0.01%     
==========================================
  Files         315      315              
  Lines      106296   106277      -19     
==========================================
- Hits        57461    57442      -19     
  Misses      48835    48835              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fraccaman Fraccaman marked this pull request as ready for review June 8, 2024 07:54
@Fraccaman Fraccaman requested a review from grarco June 8, 2024 07:54
grarco
grarco previously approved these changes Jun 9, 2024
brentstone added a commit that referenced this pull request Jun 10, 2024
* fraccaman/remove-multipler-check-governance:
  changelog: add #3390
  some small changes
  minors
  minors
  remove epoch multipler check for governance
@brentstone brentstone merged commit 5d19945 into main Jul 5, 2024
17 of 19 checks passed
@brentstone brentstone deleted the fraccaman/remove-multipler-check-governance branch July 5, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the need for governance proposal epochs to be a multiple of 3
3 participants