split transfer tx #3297
Merged
split transfer tx #3297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzemanovic
force-pushed
the
tomas/split-transfer-tx
branch
from
a49637e
to
e27a570
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3297 +/- ##
==========================================
- Coverage 53.93% 53.57% -0.36%
==========================================
Files 314 316 +2
Lines 105739 106457 +718
==========================================
+ Hits 57027 57031 +4
- Misses 48712 49426 +714 ☔ View full report in Codecov by Sentry. |
tzemanovic
force-pushed
the
tomas/split-transfer-tx
branch
from
e27a570
to
cd09a6b
Compare
tzemanovic
added a commit
that referenced
this pull request
May 30, 2024
tzemanovic
force-pushed
the
tomas/split-transfer-tx
branch
from
cf4e9a8
to
aa45a78
Compare
grarco
reviewed
May 30, 2024
grarco
reviewed
May 30, 2024
grarco
reviewed
May 30, 2024
grarco
reviewed
May 30, 2024
crates/apps_lib/src/client/tx.rs
Outdated
| args: args::TxShieldingTransfer, | ||
| ) -> Result<(), error::Error> { | ||
| // Repeat once if the tx fails on a crossover of an epoch | ||
| for _ in 0..2 { |
There was a problem hiding this comment.
I believe this loop is only needed for shielding transactions but we don't need it when doing shielded or unshielding. Maybe @murisi can confirm this
There was a problem hiding this comment.
I believe this loop is only needed for shielding transactions but we don't need it when doing shielded or unshielding. Maybe @murisi can confirm this
Yes, agreed. You cannot submit a shielding transaction in later epochs because users would exploit this by pretending the transactions were submitted much earlier and claim a large reward. But late submissions are permitted for shielded and unshielding because there's nothing to be gained by the user by doing so.
There was a problem hiding this comment.
added one more commit to remove this from shielded transfer too - https://github.com/anoma/namada/pull/3297/files/838cec13b9d1d4b71f864b526be7addbab1d80e5..7ca37179029644c06a4f8f003e23fc3cb98c6503
Closed
grarco
previously approved these changes
May 31, 2024
tzemanovic
dismissed
grarco’s stale review
The merge-base changed after approval.
tzemanovic
added a commit
that referenced
this pull request
May 31, 2024
* origin/tomas/split-transfer-tx: update hermes ShieldingTransfer for IBC messages fixup! sdk: update for split-up transfer tx fixup! tests: update for split-up transfer tx changelog: add #3297 sdk/tx: fix the display of insufficient funds for non-native token wasm_for_tests: update Cargo.lock wasm/tx_ibc: update the shielded transfer benches: update for split-up transfer tx encoding_spec: update for split-up transfer tx tests: update for split-up transfer tx node/bench_utils: update for split-up transfer tx apps: update for split-up transfer tx apps_lib: update for split-up transfer tx light_sdk: update for split-up transfer tx namada/protocol: rm dead code namada: update ibc path imports sdk: update for split-up transfer tx wasm: add shielded, shielding and unshielding transfer wasm/tx_transparent_transfer: remove the shielded section wasm: rename `tx_transfer` to `tx_transparent_transfer` move most of core IBC types into IBC crate replace the single `Transfer` struct with 4 distinct ones
tzemanovic
added a commit
that referenced
this pull request
May 31, 2024
tzemanovic
added a commit
that referenced
this pull request
May 31, 2024
Fraccaman
added a commit
that referenced
this pull request
Jun 3, 2024
* up/tomas/split-transfer-tx: retry tx submission on shielding fixup! apps_lib: update for split-up transfer tx fixup! apps_lib: update for split-up transfer tx update hermes ShieldingTransfer for IBC messages fixup! sdk: update for split-up transfer tx fixup! tests: update for split-up transfer tx changelog: add #3297 sdk/tx: fix the display of insufficient funds for non-native token wasm_for_tests: update Cargo.lock wasm/tx_ibc: update the shielded transfer benches: update for split-up transfer tx encoding_spec: update for split-up transfer tx tests: update for split-up transfer tx node/bench_utils: update for split-up transfer tx apps: update for split-up transfer tx apps_lib: update for split-up transfer tx light_sdk: update for split-up transfer tx namada/protocol: rm dead code namada: update ibc path imports sdk: update for split-up transfer tx wasm: add shielded, shielding and unshielding transfer wasm/tx_transparent_transfer: remove the shielded section wasm: rename `tx_transfer` to `tx_transparent_transfer` move most of core IBC types into IBC crate replace the single `Transfer` struct with 4 distinct ones
Fraccaman
pushed a commit
that referenced
this pull request
Jun 3, 2024
tzemanovic
force-pushed
the
tomas/split-transfer-tx
branch
from
21c9d36
to
ff29e1c
Compare
|
auto-squashed fixups |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
closes #1677, closes #3345
The transfer CLI command is split into:
transfer(shielded)transparent-transfershield(from transparent to shielded)unshield(from shielded to transparent)With a dedicated wasm tx for each case, respectively:
tx_shielded_transfertx_transparent_transfertx_shielding_transfertx_unshielding_transferIndicate on which release or other PRs this topic is based on
#3232 (based on 0.37)
Checklist before merging to
draft