-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit TODOs in the codebase #3234
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3234 +/- ##
==========================================
- Coverage 53.79% 53.78% -0.01%
==========================================
Files 314 314
Lines 105784 105724 -60
==========================================
- Hits 56903 56868 -35
+ Misses 48881 48856 -25 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
couple of small things
@tzemanovic @brentstone should I leave the PoS TODOs untouched? |
rebased on |
* origin/tiago/audit-todos: Changelog for #3234 Audit TODOs in codebase
* origin/tiago/audit-todos: Changelog for #3234 Audit TODOs in codebase
Describe your changes
Closes #3179
Full list of TODOs: https://p.sicp.me/d2PNB
Unaccounted for TODOs: https://p.sicp.me/mpxUF
Indicate on which release or other PRs this topic is based on
v0.36.1
Checklist before merging to
draft