Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit TODOs in the codebase #3234

Merged
merged 2 commits into from
May 24, 2024
Merged

Audit TODOs in the codebase #3234

merged 2 commits into from
May 24, 2024

Conversation

sug0
Copy link
Contributor

@sug0 sug0 commented May 13, 2024

Describe your changes

Closes #3179

Full list of TODOs: https://p.sicp.me/d2PNB
Unaccounted for TODOs: https://p.sicp.me/mpxUF

Indicate on which release or other PRs this topic is based on

v0.36.1

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented May 13, 2024

Codecov Report

Attention: Patch coverage is 52.58621% with 55 lines in your changes are missing coverage. Please review.

Project coverage is 53.78%. Comparing base (c7d79f4) to head (5817d5f).
Report is 3 commits behind head on main.

Files Patch % Lines
crates/apps_lib/src/client/rpc.rs 0.00% 9 Missing ⚠️
crates/node/src/shell/mod.rs 33.33% 8 Missing ⚠️
crates/node/src/broadcaster.rs 0.00% 7 Missing ⚠️
crates/apps_lib/src/cli/api.rs 0.00% 5 Missing ⚠️
crates/sdk/src/queries/mod.rs 0.00% 4 Missing ⚠️
crates/core/src/key/secp256k1.rs 85.71% 3 Missing ⚠️
...rc/protocol/transactions/ethereum_events/events.rs 70.00% 3 Missing ⚠️
...ledger/native_vp/ethereum_bridge/bridge_pool_vp.rs 0.00% 3 Missing ⚠️
crates/node/src/shell/prepare_proposal.rs 0.00% 3 Missing ⚠️
..._bridge/src/protocol/validation/ethereum_events.rs 0.00% 2 Missing ⚠️
... and 7 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3234      +/-   ##
==========================================
- Coverage   53.79%   53.78%   -0.01%     
==========================================
  Files         314      314              
  Lines      105784   105724      -60     
==========================================
- Hits        56903    56868      -35     
+ Misses      48881    48856      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

crates/sdk/src/tx.rs Outdated Show resolved Hide resolved
Copy link
Member

@batconjurer batconjurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of small things

grarco
grarco previously approved these changes May 16, 2024
@sug0
Copy link
Contributor Author

sug0 commented May 16, 2024

@tzemanovic @brentstone should I leave the PoS TODOs untouched?

@sug0 sug0 marked this pull request as ready for review May 17, 2024 16:24
sug0 added a commit that referenced this pull request May 17, 2024
batconjurer
batconjurer previously approved these changes May 21, 2024
@sug0
Copy link
Contributor Author

sug0 commented May 22, 2024

rebased on v0.36.1

tzemanovic added a commit that referenced this pull request May 23, 2024
* origin/tiago/audit-todos:
  Changelog for #3234
  Audit TODOs in codebase
brentstone added a commit that referenced this pull request May 23, 2024
* origin/tiago/audit-todos:
  Changelog for #3234
  Audit TODOs in codebase
@brentstone brentstone merged commit e774efd into main May 24, 2024
17 of 19 checks passed
@brentstone brentstone deleted the tiago/audit-todos branch May 24, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audit for ToDos in the codebase
5 participants