Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify the checksum of downloaded wasm files #3119

Merged
merged 2 commits into from
May 9, 2024

Conversation

sug0
Copy link
Contributor

@sug0 sug0 commented Apr 24, 2024

Describe your changes

Verify the checksum of dowloaded wasm artifacts, before completing the ledger's bootup procedure.

Indicate on which release or other PRs this topic is based on

v0.34.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

@sug0 sug0 added the security label Apr 24, 2024
@sug0 sug0 force-pushed the tiago/check-wasm-digests-after-download branch from e6d8bf5 to 092f0c4 Compare April 24, 2024 09:02
sug0 added a commit that referenced this pull request Apr 24, 2024
@sug0 sug0 requested review from tzemanovic and cwgoes April 24, 2024 09:03
@sug0 sug0 marked this pull request as ready for review April 24, 2024 09:03
@brentstone brentstone force-pushed the tiago/check-wasm-digests-after-download branch from 6cce66a to 34f5fca Compare April 29, 2024 17:18
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 31 lines in your changes are missing coverage. Please review.

Project coverage is 59.40%. Comparing base (ea843f7) to head (34f5fca).
Report is 7 commits behind head on main.

Files Patch % Lines
crates/apps/src/lib/wasm_loader/mod.rs 0.00% 31 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3119      +/-   ##
==========================================
- Coverage   59.41%   59.40%   -0.02%     
==========================================
  Files         298      298              
  Lines       92326    92336      +10     
==========================================
- Hits        54853    54849       -4     
- Misses      37473    37487      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

brentstone added a commit that referenced this pull request Apr 29, 2024
* tiago/check-wasm-digests-after-download:
  Changelog for #3119
  Verify the checksum of downloaded wasm files
@brentstone brentstone merged commit fee5c7b into main May 9, 2024
15 of 19 checks passed
@brentstone brentstone deleted the tiago/check-wasm-digests-after-download branch May 9, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants