Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make wasm substorage governable #3100

Merged
merged 6 commits into from
May 9, 2024
Merged

Conversation

Fraccaman
Copy link
Member

@Fraccaman Fraccaman commented Apr 19, 2024

Describe your changes

Partially addresses #3061

Indicate on which release or other PRs this topic is based on

v0.34.0

Checklist before merging to draft

  • I have added a changelog
  • Git history is in acceptable state

Copy link

codecov bot commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.41%. Comparing base (ea843f7) to head (6f498b7).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3100   +/-   ##
=======================================
  Coverage   59.41%   59.41%           
=======================================
  Files         298      298           
  Lines       92326    92325    -1     
=======================================
+ Hits        54853    54855    +2     
+ Misses      37473    37470    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Fraccaman Fraccaman requested a review from grarco April 19, 2024 11:33
@Fraccaman Fraccaman marked this pull request as ready for review April 19, 2024 11:33
@Fraccaman Fraccaman mentioned this pull request Apr 19, 2024
grarco
grarco previously approved these changes Apr 19, 2024
@grarco grarco dismissed their stale review April 19, 2024 16:34

Didn't see the failing tests

tzemanovic
tzemanovic previously approved these changes Apr 19, 2024
Copy link
Member

@tzemanovic tzemanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good % clippy fixes

@yito88
Copy link
Member

yito88 commented Apr 24, 2024

IBC E2E tests failed since Hermes needed to be updated.
The following tests passed with https://github.com/heliaxdev/hermes/tree/1.7.4-namada-3100 in my env.

  • e2e::ibc_tests::run_ledger_ibc_with_hermes
  • e2e::ibc_tests::pgf_over_ibc_with_hermes
  • e2e::ibc_tests::ibc_rate_limit
  • e2e::ibc_tests::proposal_ibc_token_inflation

brentstone added a commit that referenced this pull request Apr 26, 2024
* fraccaman/governable-wasm-txs:
  fix clippy
  added changelog
  improve test
  move wasm substorage under parameters vp
brentstone added a commit that referenced this pull request Apr 26, 2024
* fraccaman/governable-wasm-txs:
  fix clippy
  added changelog
  improve test
  move wasm substorage under parameters vp
brentstone added a commit that referenced this pull request Apr 26, 2024
* fraccaman/governable-wasm-txs:
  fix clippy
  added changelog
  improve test
  move wasm substorage under parameters vp
@brentstone brentstone force-pushed the fraccaman/governable-wasm-txs branch from a9721cb to d5a017e Compare April 27, 2024 02:18
brentstone added a commit that referenced this pull request May 8, 2024
* origin/fraccaman/governable-wasm-txs:
  fix parameters vp
  rebuild wasms for tests
  fix clippy
  added changelog
  improve test
  move wasm substorage under parameters vp
@brentstone brentstone merged commit 5c52b4c into main May 9, 2024
14 of 19 checks passed
@brentstone brentstone deleted the fraccaman/governable-wasm-txs branch May 9, 2024 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants