Optimize find delegation validators #3043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brentstone
force-pushed
the
brent/delegation-validators
branch
from
7d2c466
to
1c251c2
Compare
2 tasks
brentstone
force-pushed
the
brent/delegation-validators
branch
from
1c251c2
to
8fcfbeb
Compare
tzemanovic
reviewed
Apr 10, 2024
tzemanovic
reviewed
Apr 10, 2024
tzemanovic
reviewed
Apr 10, 2024
brentstone
added a commit
that referenced
this pull request
Apr 10, 2024
brentstone
force-pushed
the
brent/delegation-validators
branch
from
8fcfbeb
to
c684350
Compare
thanks, think I still may include the pruning of |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3043 +/- ##
==========================================
+ Coverage 59.39% 59.49% +0.09%
==========================================
Files 298 298
Lines 92771 92967 +196
==========================================
+ Hits 55104 55310 +206
+ Misses 37667 37657 -10 ☔ View full report in Codecov by Sentry. |
Closed
brentstone
force-pushed
the
brent/delegation-validators
branch
from
c684350
to
f670a03
Compare
tzemanovic
reviewed
Apr 16, 2024
tzemanovic
reviewed
Apr 16, 2024
tzemanovic
reviewed
Apr 16, 2024
tzemanovic
previously approved these changes
Apr 18, 2024
brentstone
added a commit
that referenced
this pull request
Apr 18, 2024
* brent/delegation-validators: better comment use unslashed bond amounts in `find_delegations` fix from comments changelog: add #3043 prune old `prev_ranges` data fix edge case (fully unbond then rebond) fixes from review comments fix and finish test new approach don't merklize delegation targets improve nomenclature and comments rename and fix rpc fns to get delegator's target validators track all validators to which an account has bonded tokens
brentstone
added a commit
that referenced
this pull request
Apr 18, 2024
* brent/delegation-validators: better comment use unslashed bond amounts in `find_delegations` fix from comments changelog: add #3043 prune old `prev_ranges` data fix edge case (fully unbond then rebond) fixes from review comments fix and finish test new approach don't merklize delegation targets improve nomenclature and comments rename and fix rpc fns to get delegator's target validators track all validators to which an account has bonded tokens
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Closes #3015.
Indicate on which release or other PRs this topic is based on
v0.33.0
Checklist before merging to
draft