Streamlining is:due, prop:due, and the FutureDue graph
#904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* now they are shown as due in the past * before that they were always displayed as due today
examples: * x0 = -66 and x1 = -64 should yield 65-66 days ago instead of 64-65 days ago * x0 = -2 and x1 = 0 should yield 1-2 days ago instead of 0-1 days ago
|
Looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are all issues that rose up, when I was working on #897, specifically on the
FutureDuegraph.This one is definitely a bug:
The Histogram graph for the stats had a one-off error, when displaying past ranges. The easiest way is to look at the
FutureDuegraph with Backlog enabled.The first "future" label reads: "In 0-4 days".
The first past label reads: "0-4 days ago". This should actually be "1-5" days ago.
This rest of the changes streamline how
is:due,prop:due, and theFutureDuegraph deal with due dates:is:dueselector did not consider PreviewRepeat cards. Now it does.prop:dueselector did not search for Learning or PreviewRepeat cards. Now it does. This requires having SQL do some math. Something I stumbled upon is that in SQL, dividing two integer values automatically does integer division.Now these three features allow for a few sanity tests:
-prop:due<=0 is:dueshould only ever show learning / preview repeat cards, which will be due some time later today, but are not yet.prop:due>=x prop:due<=yshould yield n cards. Additionally, when it shows "x-y days ago: n cards due", searching forprop:due<=-x prop:due>=-yshould yield n cards.