Added --enable-hypopg option

CHANGELOG.md

@@ -1,6 +1,7 @@
 ## 0.5.0 (unreleased)
 
 - Added support for normalized queries
+- Added `--enable-hypopg` option
 - Improved output when HypoPG not installed
 - Changed `--pg-stat-activity` to run for one second
 - Detect input format based on file extension

lib/dexter/client.rb

@@ -68,6 +68,7 @@ def parse_args(args)
  o.separator "Indexing options:"
  o.boolean "--analyze", "analyze tables that haven't been analyzed in the past hour", default: false
  o.boolean "--create", "create indexes", default: false
+ o.boolean "--enable-hypopg", "enable the HypoPG extension", default: false
  o.array "--exclude", "prevent specific tables from being indexed"
  o.string "--include", "only include specific tables"
  o.integer "--min-cost-savings-pct", default: 50, help: false

lib/dexter/indexer.rb

@@ -115,16 +115,12 @@ def check_extension
  end
 
  if extension["installed_version"].nil?
- create_extension
- end
- end
-
- def create_extension
- suppress_messages do
- execute("CREATE EXTENSION hypopg")
+ if @options[:enable_hypopg]
+ execute("CREATE EXTENSION hypopg")
+ else
+ raise Dexter::Abort, "Run `CREATE EXTENSION hypopg` or pass --enable-hypopg"
+ end
  end
- rescue PG::InsufficientPrivilege
- raise Dexter::Abort, "Use a superuser to run: CREATE EXTENSION hypopg"
  end
 
  def reset_hypothetical_indexes

test/test_helper.rb

@@ -8,6 +8,7 @@
 $conn.exec <<-SQL
 SET client_min_messages = warning;
 CREATE EXTENSION IF NOT EXISTS hstore;
+CREATE EXTENSION IF NOT EXISTS hypopg;
 DROP TABLE IF EXISTS posts CASCADE;
 CREATE TABLE posts (
  id int,