Fixed error with auto_explain - fixes #48

ankane · Jan 6, 2024 · 0b9fedc · 0b9fedc
1 parent e3ea177
commit 0b9fedc
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 ## 0.5.2 (unreleased)
 
 - Switched to `GENERIC_PLAN` for Postgres 16
+- Fixed error with `auto_explain`
 - Fixed warning with Ruby 3.3
 
 ## 0.5.1 (2023-05-27)

diff --git a/lib/dexter/indexer.rb b/lib/dexter/indexer.rb
@@ -185,7 +185,7 @@ def create_hypothetical_indexes(queries)
 
  # get initial costs for queries
  calculate_plan(queries)
- explainable_queries = queries.select { |q| q.explainable? && q.high_cost? }
+ explainable_queries = queries.select { |q| q.plans.any? && q.high_cost? }
 
  # filter tables for performance
  tables = Set.new(explainable_queries.flat_map(&:tables))

diff --git a/lib/dexter/query.rb b/lib/dexter/query.rb
@@ -31,7 +31,7 @@ def tree
  end
 
  def explainable?
- plans.any?
+ plans.size >= 3
  end
 
  def costs