Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtered the users list to hide the current logged in user #145

Merged
merged 1 commit into from
Oct 8, 2018

Conversation

flacode
Copy link
Contributor

@flacode flacode commented Oct 7, 2018

Description

Filters the user list API to show all users except for the current logged in user.

Fixes #143

Type of Change:

  • Code

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Fixed tests related to the list users API for both verified and non-verified users.

Checklist:

Delete irrelevant options.

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas

Code/Quality Assurance Only

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@flacode flacode force-pushed the hide-logged-in-user branch 4 times, most recently from 960a0c8 to 0fad29d Compare October 7, 2018 20:23
@isabelcosta
Copy link
Member

isabelcosta commented Oct 7, 2018

@flacode you did a wonderful job with this PR :D you respected the PR template, you did a squashed commit with an appropriate message and added a test to support your code. I see your commit does not identify your GitHub account, think you can fix that if you want to configure git to know your email with this - https://help.github.com/articles/setting-your-commit-email-address-in-git/ .. in this way you appear on the Contributors page on GitHub repository

isabelcosta
isabelcosta previously approved these changes Oct 7, 2018
Copy link
Member

@isabelcosta isabelcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with this PR :D

@flacode
Copy link
Contributor Author

flacode commented Oct 8, 2018

Thank you @isabelcosta, I have fixed it.

@isabelcosta isabelcosta merged commit 71e5ff9 into anitab-org:develop Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter Users list to hide the current logged in user
3 participants