278 launcher #1
Merged
278 launcher #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -98,6 +106,10 @@ var normalizeConfig = function(config) { | |||
| log.warn('"reporter" is deprecated, use "reporters" instead'); | |||
| } | |||
|
|
|||
| if(config.browsers) { | |||
There was a problem hiding this comment.
Better if(helper.isDefined(config.browsers)
|
So, if you pull this in, then rebase (squash) the branch you'll be good to go for testacular#317 |
|
@DavidSouther thanks for the help! I can squash once I've addressed some of the other comments, just wanted to check whether there is any convention regarding attribution that I should observe. If I understand right, a squash would make it appear as if everything in the commit was my doing and I don't want to step on any toes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normalize the
browsersconfig param so users can either use the original["Chrome"]style or the new[{name: "Chrome"}]style, and handles passing additionalargs:in the object.