This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Removes the type_guard.* test. #932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this test was using the goog.isDef which was deprecated in favor of ' !== undefined'. However, since we run this test without externs, it is currently broken because 'undefined' is *ahem* not defined to Closure. Instead, of fixing it yet once again, I noticed that this test doesn't test anything significant, because the resulting .d.ts doesn't depend on the function implemenation. So this time I am just deleting it.
evmar
approved these changes
Oct 8, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this test was using the goog.isDef which was deprecated in
favor of ' !== undefined'. However, since we run this test without
externs, it is currently broken because 'undefined' is ahem not
defined to Closure.
Instead, of fixing it yet once again, I noticed that this test doesn't
test anything significant, because the resulting .d.ts doesn't depend on
the function implemenation. So this time I am just deleting it.