This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
Make DeclarationGeneratorTest junit4 parametirized test. #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkirov
reviewed
Aug 3, 2019
There was a problem hiding this comment.
Looks good but can you add some text to "https://github.com/angular/clutz/blob/master/DEVELOPER.md"
about your claim that this allows to "easily rerun single test in IDE." I am not an expert in Java development, and we have a lot of JS/TS contributors that would benefit.
I think most people use intellij these days, so ok to only describe that (if that was your intent).
|
Done. Updated DEVELOPER.md and also migrated TypeScriptGeneratorTest and TypeScriptGeneratorMultiTest to parameterized tests. |
|
@rkirov could you take a look? |
rkirov
approved these changes
Aug 9, 2019
It allows to easily rerun single test in IDE. TypeScriptGeneratorMultiTests.java renamed to TypeScriptGeneratorMultiTest.java TypeScriptGeneratorTests.java renamed to TypeScriptGeneratorTest.java for some reason git failed to detect it
|
Done. Updated commit message. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It allows to easily rerun single test in IDE.