fix(core): support injection of object with null constructor. #56553
Conversation
JeanMeche
added
the
action: review
| @@ -211,7 +211,7 @@ function handleInstanceCreatedByInjectorEvent( | |||
| if (typeof value === 'object') { | |||
| standaloneComponent = value?.constructor as Type<unknown>; | |||
| } | |||
| if (standaloneComponent === undefined || !isStandaloneComponent(standaloneComponent)) { | |||
| if (standaloneComponent == undefined || !isStandaloneComponent(standaloneComponent)) { | |||
There was a problem hiding this comment.
I'd propose adding a quick comment here to mention that we handle both null and undefined (i.e. that the == is intentional).
There was a problem hiding this comment.
A test would also be desirable. You may also considering widening the type of standaloneComponent to include null, as currently there's no indication that the == can make a difference vs ===
There was a problem hiding this comment.
Object.constructor is defined as Function | undefined, won't even consider null if I give it let standaloneComponent: Type<unknown> | undefined | null = undefined;, so I'l go with the comment.
There was a problem hiding this comment.
That's because of the (unsound) cast to Type<unknown>, which would cause any null in the declaration site to become irrelevant.
AndrewKushnir
added
action: cleanup
JeanMeche
force-pushed
the
core/di-null-ctor
branch
2 times, most recently
from
ec79c16
to
1946a66
Compare
This is debug only code, it shouldn't have any consequences on prod build. fixes angular#56552
JeanMeche
force-pushed
the
core/di-null-ctor
branch
from
1946a66
to
7b8f801
Compare
JeanMeche
added
action: merge
|
This PR was merged into the repository by commit 331b30e. The changes were merged into the following branches: main, 18.0.x, 18.1.x |
This is debug only code, it shouldn't have any consequences on prod build.
fixes #56552