feat(core): Add async run method on ExperimentalPendingTasks
#56546
+75
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
target: minor
angular-robot
bot
added
detected: feature
This helper method is simply a convenience function that reduces some boilerplate with manually adding and removing a task around some asynchronous function. There is a temporary decision here to _not_ return the result of the async function to discourage uses that would allow the application to become stable before making the necessary updates to the state, i.e. ``` const result = await pendingTasks.run(() => queueMicrotask(() => 'value')); this.state.set(result); ``` In the above example, the pending task is removed before the state is set. If this was the last task, the application will become stable. Because we respond to the stability synchronously, this would cause serialization before the state is updated. There are several potential solutions, including: * Not removing the task synchronously from the internal `PendingTasks` service * Not setting stability on ApplicationRef synchronously when the last task is removed * Not responding to `whenStable` synchronously in SSR (and fixture.whenStable?) As things stand today, we need to instead write the APIs which use pending tasks in a way that encourages using the pending tasks in a way that will work with the synchronous stability when the last task is removed.
pullapprove
bot
requested review from
AndrewKushnir,
pkozlowski-opensource and
thePunderWoman
thePunderWoman
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helper method is simply a convenience function that reduces some boilerplate with manually adding and removing a task around some asynchronous function. There is a temporary decision here to not return the result of the async function to discourage uses that would allow the application to become stable before making the necessary updates to the state, i.e.
In the above example, the pending task is removed before the state is set. If this was the last task, the application will become stable. Because we respond to the stability synchronously, this would cause serialization before the state is updated. There are several potential solutions, including:
PendingTasksservicewhenStablesynchronously in SSR (and fixture.whenStable?)As things stand today, we need to instead write the APIs which use pending tasks in a way that encourages using the pending tasks in a way that will work with the synchronous stability when the last task is removed.