-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate @let into the runtime #56527
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crisbeto looks great, just left a few minor comments.
Adds the implementation of the following new instructions: * `declareLet` - creation-time instruction that initializes the slot for a let declaration. * `storeLet` - update-time instruction that stores the current value of a let declaration. * `readContextLet` - instruction that reads the stored value of a let declaration from a different view. On top of the instructions, it also introduces a new `LetDeclaration` TNode type. The new TNode is nececessary for DI to work correctly in pipes inside the let expression, as well as for proper hydration support.
Updates the hydration logic to account for the fact that let declarations don't create a DOM node.
Thank you for the feedback @AndrewKushnir, it has been addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@crisbeto looks great, thanks! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed-for: public-api
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Reviewed-for: public-api
Reviewed-for: fw-core
This PR was merged into the repository by commit 7dfe302. The changes were merged into the following branches: main, 18.0.x |
Adds the implementation of the following new instructions: * `declareLet` - creation-time instruction that initializes the slot for a let declaration. * `storeLet` - update-time instruction that stores the current value of a let declaration. * `readContextLet` - instruction that reads the stored value of a let declaration from a different view. On top of the instructions, it also introduces a new `LetDeclaration` TNode type. The new TNode is nececessary for DI to work correctly in pipes inside the let expression, as well as for proper hydration support. PR Close #56527
Updates the hydration logic to account for the fact that let declarations don't create a DOM node. PR Close #56527
Updates the hydration logic to account for the fact that let declarations don't create a DOM node. PR Close #56527
Includes the following changes that integrate the new
@let
syntax into the runtime.refactor(core): integrate let instructions into the runtime
Adds the implementation of the following new instructions:
declareLet
- creation-time instruction that initializes the slot for a let declaration.storeLet
- update-time instruction that stores the current value of a let declaration.readContextLet
- instruction that reads the stored value of a let declaration from a different view.On top of the instructions, it also introduces a new
LetDeclaration
TNode type. The new TNode is nececessary for DI to work correctly in pipes inside the let expression, as well as for proper hydration support.refactor(core): support let declarations during hydration
Updates the hydration logic to account for the fact that let declarations don't create a DOM node.