Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs about HTTP testing #56518

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

CodeF0x
Copy link

@CodeF0x CodeF0x commented Jun 19, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

The order of the http testing related providers is pretty important and doing it wrong made my tests fail.

What is the new behavior?

Added a small heads up to always keep the order in mind

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

google-cla bot commented Jun 19, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@pullapprove pullapprove bot requested a review from crisbeto June 19, 2024 14:26
@angular-robot angular-robot bot added the area: docs Related to the documentation label Jun 19, 2024
@ngbot ngbot bot added this to the Backlog milestone Jun 19, 2024
@JeanMeche
Copy link
Member

Hi, can you please sign the CLA for the PR to go foward, thank you.

@CodeF0x
Copy link
Author

CodeF0x commented Jun 26, 2024

Hi @JeanMeche, sorry for keeping you waiting. I signed the CLA.

@JeanMeche
Copy link
Member

JeanMeche commented Jun 26, 2024

Can you check that you signed it with <co****t​@codef0x.dev> (the email used by the commit), the check still returns an error.

@CodeF0x
Copy link
Author

CodeF0x commented Jun 26, 2024

I triggered the CLA check again, now it seems to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs Related to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants