Unpack vars to correct version_compare issue #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I discovered an issue with the `version_compare` when running this role via Ansible 2.3 on Ubuntu 12.04. It seems that the interpreter can get confused in the tightly packed vars, so I broke out version comparators into their own vars. This seems to have fixed the issue.
|
I want to look into this more, see why this is necessary. |
|
I tested out this and it appeared to stop my version_compare issues I was experiencing in #173 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered an issue with the
version_comparewhen running this role via Ansible 2.3 on Ubuntu 12.04. It seems that the interpreter can get confused in the tightly packed vars, so I broke out version comparators into their own vars. This seems to have fixed the issue.