[Core] Remove unnecessary gcs rpc reply status conversion (ray-projec…

…t#47022) The status conversion is already done inside gcs_rpc_client
angelinalg · Aug 8, 2024 · 2f59686 · 2f59686
1 parent c634872
commit 2f59686
Showing 1 changed file with 3 additions and 15 deletions.
diff --git a/src/ray/gcs/gcs_client/accessor.cc b/src/ray/gcs/gcs_client/accessor.cc
@@ -289,11 +289,7 @@ Status ActorInfoAccessor::AsyncRegisterActor(const ray::TaskSpecification &task_
  request.mutable_task_spec()->CopyFrom(task_spec.GetMessage());
  client_impl_->GetGcsRpcClient().RegisterActor(
  request,
- [callback](const Status & /*unused*/, rpc::RegisterActorReply &&reply) {
- auto status =
- reply.status().code() == (int)StatusCode::OK
- ? Status()
- : Status(StatusCode(reply.status().code()), reply.status().message());
+ [callback](const Status &status, rpc::RegisterActorReply &&reply) {
  callback(status);
  },
  timeout_ms);
@@ -321,12 +317,8 @@ Status ActorInfoAccessor::AsyncKillActor(const ActorID &actor_id,
  request.set_no_restart(no_restart);
  client_impl_->GetGcsRpcClient().KillActorViaGcs(
  request,
- [callback](const Status & /*unused*/, rpc::KillActorViaGcsReply &&reply) {
+ [callback](const Status &status, rpc::KillActorViaGcsReply &&reply) {
  if (callback) {
- auto status =
- reply.status().code() == (int)StatusCode::OK
- ? Status()
- : Status(StatusCode(reply.status().code()), reply.status().message());
  callback(status);
  }
  },
@@ -341,11 +333,7 @@ Status ActorInfoAccessor::AsyncCreateActor(
  rpc::CreateActorRequest request;
  request.mutable_task_spec()->CopyFrom(task_spec.GetMessage());
  client_impl_->GetGcsRpcClient().CreateActor(
- request, [callback](const Status & /*unused*/, rpc::CreateActorReply &&reply) {
- auto status =
- reply.status().code() == (int)StatusCode::OK
- ? Status()
- : Status(StatusCode(reply.status().code()), reply.status().message());
+ request, [callback](const Status &status, rpc::CreateActorReply &&reply) {
  callback(status, std::move(reply));
  });
  return Status::OK();